Set warning-mode none for gradle build #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 78 78
Lines 2058 2061 +3
=========================================
+ Hits 2058 2061 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gradle likes to fail your builds when you use deprecated features for the next major version, unless you explicitly opt out.
OpenSearch has explicitly opted out with this line in
gradle.properties:Updating our CI to use the equivalent command line switch. This ignores both the gradle deprecation warnings and the javadoc warning/errors.
Also changed JDK to 21, since that's soon to be required for OpenSearch 3.x (
mainbranch), and JDK 17 is the minimum for Gradle 8.10 which we're using via the wrapper.Issues Resolved
Fixes #194
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.